NetLogo / NetLogo-Libraries

The central repository for the extensions listed in the NetLogo Extension Manager
15 stars 24 forks source link

add rngs-2.0 #28

Closed AFMac closed 4 years ago

AFMac commented 5 years ago

Added update to expanded random number generation extension.

AFMac commented 4 years ago

Jeremy-

I'll update the download link, no sweat. The rngs.jar file did have a manifest file included, although I used 6.0 instead of 6.1, following the example on the extension authoring page. I noticed the warning message pop-up as well when I ran a quick test. I updated the manifest to point 6.1 and remade the .jar file and am still getting the same pop-up. Is there something I'm missing?

LaCuneta commented 4 years ago

Here is what I see in the MANIFEST.MF file inside the jar:

Manifest-Version: 1.0
Extension-Name: rngs
Class-Manager: RNGExtension
Created-By: 11.0.5 (AdoptOpenJDK)

I'm not exactly sure why just the NetLogo API version setting would be getting dropped. Our docs say there needs to be a newline at the end of file. Could that be the problem?

AFMac commented 4 years ago

Doh! Newline was the issue. Will rewicker everything and re-commit. I'll also expand the documentation a little: I included an example model with syntax usage as part of the distro, and will ensure at least that level of detail is reflected.

Thanks again!

AFMac commented 4 years ago

@LaCuneta Changes made as per above. Download link corrected along with the manifest file. Thanks for the help!