search

NetLogo / NetLogo

turtles, patches, and links for kids, teachers, and scientists
http://ccl.northwestern.edu/netlogo/
995 stars 240 forks source link

Remove `sbt` and `nightly.sh` scripts #2252

Open LaCuneta opened 1 month ago

LaCuneta commented 1 month ago

The sbt script NetLogo uses should no longer be necessary. It 1) sets JAVA_HOME based on the system, 2) downloads an sbt launcher, and 3) sets some Java system properties. 1) can be handled by the developer or if we really want an automated system look into a purpose-built Java version manager like Jabba or jEnv. 2) is not needed as long as the user installs any recent sbt version via the normal ways to install software on their system. sbt will download the exact correct version it needs thereafter. 3) If these are still necessary, they can be specified by a .jvmopts file, like Tortoise does.

The nightly.sh script has been wholly supplanted by the GitHub Actions workflow file, so should be safe to remove. It may be mentioned in the wiki here, so those references would need to be cleaned up.

SethTisue commented 1 month ago

agree about the sbt script — at the time I added it, there wasn't yet a single standard launcher script provided by the sbt maintainers, so checking a project-specific one into version control was a common practice. in 2024, it's definitely not common practice anymore