5.2.1 regression: weirdly large font size in output area

[SethTisue]

Matrix Example with font size of output area set to 12. left is 5.2, right is 5.2.1. 5.2.2-RC2 is similar to 5.2.1

[nicolaspayette]

I hope it's not a regression caused by https://github.com/NetLogo/NetLogo/pull/805, but it could be...

[mrerrormessage]

I'm pretty sure that the problem is related to this call to fontSize(Int). When creating an output widget in a new model, the font is sized normally, but if saved and reopened, the font is noticeably larger. I'm not clear enough on how widgets are loaded to know what changes need to be made, but perhaps you all have some ideas?

[SethTisue]

the horror, the horror

[nicolaspayette]

Two parts to this:

• The bigger font in Matrix Example was most probably a consequence of #802 (the bug that was fixed by #805). The bigger font was introduced (by me) in https://github.com/NetLogo/models/commit/5e586ed6360ac2d624b120f7ac9eafbe0095bb78 and is now fixed by https://github.com/NetLogo/models/commit/0c4aaaf40db9eb1937fe52675d70bbcc9877b7ba.
• There was, nonetheless, a regression introduced by #805: the line that @mrerrormessage rightly suspected to be guilty should have been using the proper fontSize_= setter instead of directly setting outputArea.fontSize. That explains why the "Edit..." dialog for the output widget was showing the font as being 12 points even if it was actually 20. This should be fixed by https://github.com/NetLogo/NetLogo/pull/899.

[mrerrormessage]

Closed by #899