NetLogo / models

NetLogo Models Library
106 stars 95 forks source link

Duplicates between book models and sample models: El Farol and DLA Simple #40

Closed nicolaspayette closed 9 years ago

nicolaspayette commented 9 years ago

As in #39, our "every model has a unique name" fails for two book models that have duplicates under the Sample Models folders:

The versions have already started to diverge: some minor improvements that were made in the book versions were not made in the sample models versions. The other difference is that the book versions have the ACKNOWLEDGMENT section and book specific HOW TO CITE in their info tabs.

Should we:

  1. Rename one of the versions, for each model.
  2. Use the book versions in the Sample Models folder.

In the name of fighting entropy, I advocate 2.

@UriCCL, what do you think?

arthurhjorth commented 9 years ago

I am very much in favor of 2 too. Particularly since the book versions are better versions of the old models.

Arthur Hjorth PhD Student, Learning Sciences Center for Connected Learning http://ccl.northwestern.edu/ Northwestern University

e: arthur.hjorth@u.northwestern.edu s: arthurhjorth m: +1 (773) 943-0013

On Sun, Mar 29, 2015 at 7:12 PM Nicolas Payette notifications@github.com wrote:

As in #39 https://github.com/NetLogo/models/issues/39, our "every model has a unique name" fails for two book models that have duplicates under the Sample Models folders:

  • IABM Textbook/chapter 3/El Farol Extensions/El Farol vs. Sample Models/Social Science/El Farol
  • Sample Models/Chemistry & Physics/Diffusion Limited Aggregation/DLA Simple vs. IABM Textbook/chapter 3/DLA extensions/DLA Simple

The versions have already started to diverge: some minor improvements that were made in the book versions were not made in the sample models versions. The other difference is that the book versions have the ACKNOWLEDGMENT section and book specific HOW TO CITE in their info tabs.

Should we:

  1. Rename one of the versions, for each model.
  2. Use the book versions in the Sample Models folder.

In the name of fighting entropy, I advocate 2.

— Reply to this email directly or view it on GitHub https://github.com/NetLogo/models/issues/40.

nicolaspayette commented 9 years ago

@UriCCL agreed with 2 as well. I made the changes. All that is left is for @frankduncan to review and merge https://github.com/NetLogo/NetLogo/pull/749.