search

NetOfficeFw / NetOffice

🌌 Create add-ins and automation code for Microsoft Office applications.
MIT License
697 stars 143 forks source link

`Settings.IsEqualTo` compares `EnableSafeMode` incorrectly #291

Closed jozefizso closed 4 years ago

jozefizso commented 4 years ago

Two Settings objects can be compared with IsEqualTo() method.

When they differ in the EnableSafeMode value only, they are considered equal.

https://github.com/NetOfficeFw/NetOffice/blob/f2e3dcdb670338fea874a4b832e2d26ff3f27ec5/Source/NetOffice/Settings.cs#L551-L553

jozefizso commented 4 years ago

The method has also a bug which makes Settings object equal to null value.

https://github.com/NetOfficeFw/NetOffice/blob/f2e3dcdb670338fea874a4b832e2d26ff3f27ec5/Source/NetOffice/Settings.cs#L534-L535