`ResourceUtils.ReadImage()` calls itself recursively

NetOfficeFw / NetOffice

🌌 Create add-ins and automation code for Microsoft Office applications.

MIT License

697 stars 143 forks source link

`ResourceUtils.ReadImage()` calls itself recursively #292

Closed jozefizso closed 4 years ago

jozefizso commented 4 years ago

The ResourceUtils class in OfficeApi project has method ReadImage() which should implement image reading from assembly, but it incorrectly calls itself.

https://github.com/NetOfficeFw/NetOffice/blob/3b56a7420dab2d1a18d4b60ae8e12e728423cf1b/Source/Office/Tools/Contribution/ResourceUtils.cs#L128-L131

jozefizso commented 4 years ago

The ResourceUtils.ReadString() does not use the provided assembly parameter to resolve the resource.

https://github.com/NetOfficeFw/NetOffice/blob/3b56a7420dab2d1a18d4b60ae8e12e728423cf1b/Source/Office/Tools/Contribution/ResourceUtils.cs#L98-L109