search

NetOfficeFw / NetOffice

🌌 Create add-ins and automation code for Microsoft Office applications.
MIT License
697 stars 143 forks source link

Assemblies in Version 1.9 are not digitally signed #369

Closed morgars closed 1 year ago

morgars commented 1 year ago

Why are the assemblies in the nuget-Package are not longer digitally signed? e.g. https://www.nuget.org/packages/NetOfficeFw.Core

jozefizso commented 1 year ago

Hi @morgars, thanks for noticing this. I checked the signing pipeline several times before releasing 1.9 so this looks like a bug in the build script.

All assemblies and nuget packages should be signed.

morgars commented 1 year ago

Ok, thanks for the reply. Then I wait for the fix of the problem.

jozefizso commented 1 year ago

I see the problem now. The build script is not signing the assemblies in the individual project output, but in the shared output at Source\ClientApplication\bin. So the dotnet pack will use the unsinged assemblies.

jozefizso commented 1 year ago

Fixed in 1.9.1

image

morgars commented 1 year ago

Hi @jozefizso, thank you for the quick fix and the great work.