search

NetSPI / PowerUpSQL

PowerUpSQL: A PowerShell Toolkit for Attacking SQL Server
Other
2.47k stars 462 forks source link

Standardize Cmdlet Verbs #30

Closed aph3rson closed 3 years ago

aph3rson commented 6 years ago

Per Microsoft's documentation, specific verbs are to be used for Powershell cmdlets, in order to ensure some consistency between third-party modules/official functionality. This is echoed in the warning presented when importing PowerUpSQL: image

PowerUpSQL uses Create as a verb for these cmdlets:

To fix this, these cmdlets/functions should be refactored to use the New verb, which is recommended for use in instances when a new record/object is being created.

aph3rson commented 6 years ago

I'd be happy to submit a PR, if preferred.

nullbind commented 6 years ago

Hey @aph3rson,

Thanks for the request! It would be nice to make things a little cleaner. Let me take a look and see what might be impacted and I will get back to you next week.

Thanks again,

Scott

nullbind commented 3 years ago

I decided to leave the verbs as is. Thanks again for the thought though.

aph3rson commented 3 years ago

I decided to leave the verbs as is. Thanks again for the thought though.

@nullbind if that's the case, could the documentation be updated to call out the expected warning on import?
It's not documented anywhere, so folks using it can get confused and think the install was unsuccessful.