search

NetSparkleUpdater / NetSparkle

NetSparkle is a C#, cross-platform, highly-configurable software update framework with pre-built UI for .NET developers compatible with .NET 4.6.2/.NET 6+, WinForms, WPF, and Avalonia; uses Ed25519 signatures. View basic usage here in the README and try the samples for yourself.
https://netsparkleupdater.github.io/NetSparkle/
MIT License
625 stars 85 forks source link

look into getting rid of CloseApplication event/delegate #18

Closed stephenwade closed 4 years ago

stephenwade commented 7 years ago

Instead of hooking into these events to handle closing the app, the app should either hook into AboutToExitForInstallerRun, or properly handle the Application.Exit event or the Form.FormClosing event as if otherwise closed (by closing the last window or by a system shutdown).

Deadpikle commented 4 years ago

Deciding to keep CloseApplication for now so that users can have the most customization possible. AboutToExitForInstallerRun is a "pre-closing" event and shouldn't actually kill things yet, so we can't kill everything there. I'd rather they handle things through NetSparkle instead with the whole custom UI thing (since technically they could use this without WPF or WinForms!), so I'm keeping it.