NetSparkleUpdater / NetSparkle

NetSparkle is a C#, cross-platform, highly-configurable software update framework with pre-built UI for .NET developers compatible with .NET 4.6.2/.NET 6+, WinForms, WPF, and Avalonia; uses Ed25519 signatures. View basic usage here in the README and try the samples for yourself.
https://netsparkleupdater.github.io/NetSparkle/
MIT License
625 stars 85 forks source link

Image and Icon SizeModes are AutoSize - Should Be Zoom #213

Closed SeanAWalsh closed 3 years ago

SeanAWalsh commented 3 years ago

I believe that

NetSparkle.UI.WinForms.NetCore\CheckingForUpdatesWindow.Designer.cs
NetSparkle.UI.WinForms.NetCore\MessageNotificationWindow.Designer.cs
NetSparkle.UI.WinForms.NetFramework\CheckingForUpdatesWindow.Designer.cs
NetSparkle.UI.WinForms.NetFramework\MessageNotificationWindow.Designer.cs

NetSparkle.UI.WinForms.NetCore\DownloadProgressWindow.resx
NetSparkle.UI.WinForms.NetCore\UpdateAvailableWindow.resx
NetSparkle.UI.WinForms.NetFramework\DownloadProgressWindow.resx

Use AutoSize where (I think) Zoom is intended

See: https://docs.microsoft.com/en-us/dotnet/api/system.windows.forms.pictureboxsizemode?view=net-5.0

says

I note that

 NetSparkle.UI.WinForms.NetCore\ToastNotifier.designer.cs
 NetSparkle.UI.WinForms.NetFramework\ToastNotifier.designer.cs

use a SizeMode of CenterImage and the Form Constructor goes to the trouble of creating a 48 x 48 version of the icon. The others don't and so strange things happen with larger images. As I said in Issue #212, I think this may be part of issue #123's problems. I have a user with this problem (his buttons are not visible on the Form at all). I'll see if I can fix him.

Deadpikle commented 3 years ago

Fixed in 2b169dc542cfae0c34fab6091ee4db26f561fa3f and ddb336f227bc02c3837da70a062113c6b341315d

Deadpikle commented 3 years ago

Thanks for your notes on that!