search

NetSparkleUpdater / NetSparkle

NetSparkle is a C#, cross-platform, highly-configurable software update framework with pre-built UI for .NET developers compatible with .NET 4.6.2/.NET 6+, WinForms, WPF, and Avalonia; uses Ed25519 signatures. View basic usage here in the README and try the samples for yourself.
https://netsparkleupdater.github.io/NetSparkle/
MIT License
606 stars 84 forks source link

Missing buttons when HideReleaseNotes is true #400

Closed jamesweston closed 1 year ago

jamesweston commented 1 year ago

When setting HideReleaseNotes to true it removes all the buttons from the update available window and makes it impossible to install the update i have a fix in https://github.com/jamesweston/NetSparkle/commit/17b017a4ff448cf07519bfb1b217ccf34a1ece4a if you want me to submit a pull request

Original behaviour image

Fixed behaviour image

Thanks, James

Deadpikle commented 1 year ago

@jamesweston, THANK YOU for reporting this (and the fix)! This was also broken in the .NET Core version and in the Avalonia UI, so thank you for reporting it!

This fix is rolling out in 2.2.1 now via CI/CD. I cherry-pick'ed your commit and added you as a co-author on another so you'd get attribution. Thank you!

(And feel free to send in a PR along with filing an issue in the future. No problem there.)