Fix async void to be async Task everywhere #397

NetSparkleUpdater / NetSparkle

NetSparkle is a C#, cross-platform, highly-configurable software update framework with pre-built UI for .NET developers compatible with .NET 4.6.2/.NET 6+, WinForms, WPF, and Avalonia; uses Ed25519 signatures. View basic usage here in the README and try the samples for yourself.

https://netsparkleupdater.github.io/NetSparkle/

MIT License

615 stars 85 forks source link

Fix async void to be async Task everywhere #397 #523

Closed smty2018 closed 11 months ago

smty2018 commented 11 months ago

Fix async void to be async Task everywhere #397

Issue #397

smty2018 commented 11 months ago

@Deadpikle can you please review this PR?

Deadpikle commented 11 months ago

@smty2018 I will be happy to do so when I have some time. Please have some patience with me as I am very busy trying to do life right now. Will try to get to this by the end of the weekend.

At a very quick glance, the original issue's description was lackluster and "everywhere" was not meant to be literally "everywhere", just places external code could call into, e.g. the core NetSparkle library. Tests and the samples it doesn't really matter on in this case.

Deadpikle commented 11 months ago

@smty2018 Thank you for your work. Here is my feedback:

Please only change void to Task in NetSparkle.UI.* projects and the core NetSparkle lib (remove the change from the samples and test projects)
This change set is a breaking change (IUpdateDownloader would need adjusting). Are you wanting this for hacktoberfest? If so, I can create a 3.x branch and merge it into there, as #397 is a 3.x issue.
Per the above, please edit IUpdateDownloader.StartFileDownload to have the new return type. As is, your PR does not compile, which is the biggest problem here.

Thanks!