search

NetSparkleUpdater / NetSparkle

NetSparkle is a C# cross-platform software update framework for .NET developers compatible with .NET 4.6.2/.NET 6+, WinForms, WPF, and Avalonia; uses Ed25519 or DSA signatures! View basic usage here in the README or visit our website for code docs.
https://netsparkleupdater.github.io/NetSparkle/
MIT License
585 stars 81 forks source link

Changelog file name fix #572

Closed melsawy93 closed 3 months ago

melsawy93 commented 3 months ago

The changelog url in the appcast was incorrect and did not include the change log prefix passed by cli. To reproduce:

netsparkle-generate-appcast -e msi -o windows -n test-f true -u https://test.com -l https://test.com/changelog -p . --change-log-name-prefix "changelog_"

The appcast will contain: <sparkle:releaseNotesLink sparkle:signature="HQ7WFN9CBqgvtjvU17n4gCQ5YHCOf746iC+Praytks3JKez/YHNJ78eaPHTdu0hcXZeTB8EPJHef8ZTFvbAODw==">https://test.com/changelog/1.1.1.md</sparkle:releaseNotesLink>

Notice how the url doesnt include the prefix and only includes version.md.. This fix resolves this to make the resulting changelog url be https://test.com/changelog/changelog_1.1.1.md

Deadpikle commented 3 months ago

Hi @melsawy93,

Thanks for this! :-)

I believe I found a much simpler solution though. I added a failing test (3fee023b6816be9d8207557429c4fa42850f218a) first, then added a fix (45e3c8c5d20dc5f451d48c62740bd6d6ea7a6ef8). Can you try those out to see if it works? NuGet version 2.5.2, which is going through the publish process now.

melsawy93 commented 3 months ago

Hi @Deadpikle, yep I confirm it works and your solution is indeed alot cleaner. Thank you!