search

NetSparkleUpdater / NetSparkle

NetSparkle is a C# cross-platform software update framework for .NET developers compatible with .NET 4.6.2/.NET 6+, WinForms, WPF, and Avalonia; uses Ed25519 or DSA signatures! View basic usage here in the README or visit our website for code docs.
https://netsparkleupdater.github.io/NetSparkle/
MIT License
585 stars 81 forks source link

Update AppCastGenerator.SignatureManager to stream files #586

Open Deadpikle opened 1 week ago

Deadpikle commented 1 week ago

Right now, the SignatureManager file just reads in the entire file into RAM. It should be streamed instead.

https://github.com/NetSparkleUpdater/NetSparkle/blob/e0f7791a6138a131357a81bbe4ae5985e21290b9/src/NetSparkle.Tools.AppCastGenerator/SignatureManager.cs#L139-L157

Note that Ed25519Checker already supports streaming files, so the work is already basically done. https://github.com/NetSparkleUpdater/NetSparkle/blob/develop/src/NetSparkle/SignatureVerifiers/Ed25519Checker.cs