search

NetStorm84 / Metronome

A Visual Metronome
https://netstorm84.github.io/Metronome/
2 stars 15 forks source link

BPM isn't correct #37

Closed NetStorm84 closed 4 years ago

NetStorm84 commented 4 years ago

The click doesn't seem to land on the beat...

For example set the BPM to 300 and compare to this video on yourtube. Our Metronome seems too slow.

https://www.youtube.com/watch?v=6FbxFBR-hsQ&t=6s

sainitishkumar commented 4 years ago

Can I take this up?

sifat009 commented 4 years ago

I would love to work on this.

NetStorm84 commented 4 years ago

Feel free to have a go.

NetStorm84 commented 4 years ago

Did either of you guys have any luck with this one?

sifat009 commented 4 years ago

Did either of you guys have any luck with this one?

I've tried a bit but it needs some extra calculation. I couldn't come up with an idea on the first try. I'll try it agin later. If i succeed i'll send a pull request.

NetStorm84 commented 4 years ago

This still isn't working properly, if anyone else would like to try.

Jay206-Programmer commented 4 years ago

I am trying now.

NetStorm84 commented 4 years ago

Great, Thanks.

On Tue, 6 Oct 2020 at 08:08, Jay206-Programmer notifications@github.com wrote:

I am trying now.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NetStorm84/Metronome/issues/37#issuecomment-704077351, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXMTYJKPY2RLNY3HU2IHDDSJK675ANCNFSM4SDVVBCQ .

viperet commented 4 years ago

Looks like I fixed this, will make a PR

NetStorm84 commented 4 years ago

fixed in #50