search

NetSys / bess

BESS: Berkeley Extensible Software Switch
Other
313 stars 156 forks source link

Thread safety in configuration requests #920

Open kot-begemot-uk opened 5 years ago

kot-begemot-uk commented 5 years ago

Hi,

I was looking into implementing a simple L2 switch PoC using BESS as an engine and ran into the fact that most config changes in the L2Forward and IPForward are marked as non-thread-safe and thus require all workers for the modules to be stopped.

Is stopping and restarting the pipeline for such config change the intended mode of operation or we should look into making at least some of these thread safe?

kot-begemot-uk commented 5 years ago

I have not heard anything on this so I am going to assume that thread safety in config changes is actually needed as a long term feature and there is no workaround which can be used in a practical production system.

I am going to clean up my proposed changes to the l2Forward and Replicate modules and submit them in a PR to cover this.