search

NetTopologySuite / NetTopologySuite.IO.ShapeFile

The ShapeFile IO module for NTS.
33 stars 25 forks source link

Fix inconsistency for determining an Int32 #56 #57

Closed kristofdegrave closed 3 years ago

kristofdegrave commented 3 years ago

When creating a header the length of an Int32 is set to 10.

https://github.com/NetTopologySuite/NetTopologySuite.IO.ShapeFile/blob/c0819c1cfbf8c52146a0004e0e7b3a2b48044d98/src/NetTopologySuite.IO.ShapeFile/Dbase/DbaseFieldDescriptor.cs#L176-L184 With the following values: https://github.com/NetTopologySuite/NetTopologySuite.IO.ShapeFile/blob/c0819c1cfbf8c52146a0004e0e7b3a2b48044d98/src/NetTopologySuite.IO.ShapeFile/ShapefileDataWriter.cs#L97-L101

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

FObermaier commented 3 years ago

Good catch, thanks!

kristofdegrave commented 3 years ago

Yes we could. This should even be more logical. But since I'm pretty new to the framework, I don't want to make those decisions for them :)