search

NetTopologySuite / NetTopologySuite.IO.ShapeFile

The ShapeFile IO module for NTS.
35 stars 25 forks source link

Fix/dbase file descriptor #56 #59

Closed kristofdegrave closed 3 years ago

kristofdegrave commented 3 years ago

When creating a header the length of an Int32 is set to 10.

https://github.com/NetTopologySuite/NetTopologySuite.IO.ShapeFile/blob/c0819c1cfbf8c52146a0004e0e7b3a2b48044d98/src/NetTopologySuite.IO.ShapeFile/Dbase/DbaseFieldDescriptor.cs#L176-L184 With the following values: https://github.com/NetTopologySuite/NetTopologySuite.IO.ShapeFile/blob/c0819c1cfbf8c52146a0004e0e7b3a2b48044d98/src/NetTopologySuite.IO.ShapeFile/ShapefileDataWriter.cs#L97-L101

kristofdegrave commented 3 years ago

Nieuw pull request instead of #57 Done on seperate branch to allow me to stay in sync and allow me to create other PR's

airbreather commented 3 years ago

Can you please add a test that would fail without this change, and passes with this change?

kristofdegrave commented 3 years ago

@airbreather is this test enough to cover it?

kristofdegrave commented 3 years ago

@airbreather Do you need any additional tasks to be done to complete this task?