NetTopologySuite / NetTopologySuite.IO.ShapeFile

The ShapeFile IO module for NTS.
35 stars 25 forks source link

GDB missing #77

Closed reubenShilling closed 4 months ago

reubenShilling commented 3 years ago

Am I nuts or is NetTopologySuite.IO.GDB completely missing from the nuget package?

DGuidi commented 3 years ago

the GDB-related code is in the "IO.ShapeFile" nuget package, you don't need to add another package to your solution

airbreather commented 3 years ago

the GDB-related code is in the "IO.ShapeFile" nuget package, you don't need to add another package to your solution

I didn't think so... can you please double-check?

DGuidi commented 3 years ago

Ok, the GDB-related code is in this github repository, here, so I assumed that the same code is deployed in the same package.
I checked and you're right, actually GDBReader/Writer classes looks not deployed inside the nuget package.

DGuidi commented 3 years ago

as in the release description

There's now just one DLL, "NetTopologySuite.IO.Shapefile.dll"

sorry for the mistake

airbreather commented 3 years ago

We can probably just move GDBReader and GDBWriter into the main project?

DGuidi commented 3 years ago

makes sense to me, but probably we should also remove "VeDEx" references in the comments, that is a reference to a product I was working on probably 15 years ago!

reubenShilling commented 3 years ago

We can probably just move GDBReader and GDBWriter into the main project?

Thanks for the quick response guys! So am I correct in saying that as of now these two classes are not included in any NTS nuget package?

DGuidi commented 3 years ago

Yep, absolutely