search

Netatalk / netatalk

Netatalk is a Free and Open Source AFP fileserver. A *NIX or BSD system running Netatalk is capable of serving many Macintosh clients simultaneously as an AppleShare file server.
https://netatalk.io
GNU General Public License v2.0
335 stars 86 forks source link

[2.4] srvloc gone with meson build system of netatalk2? #1140

Closed VorpalBlade closed 2 months ago

VorpalBlade commented 3 months ago

Describe the bug I was looking at updating the AUR package to netatalk 2.4.0, and noticed that there is a new meson build system. I currently configure the AUR package to use srvloc as that is the only way I found being able to do service discovery with early OS X and late OS 9 (and I have computers from that era). As far as I know zeroconf and srvloc are mutually exclusive (unfortunately). With meson I can't find the option to enable srvloc. Have you forgot to port that over?

To Reproduce Look through meson_options.txt trying to figure out how to migrate to the new build system.

Expected behavior srvloc support should not be dropped

Environment

Logs Attach syslogs from the malfunctioning process, maxdebug log level

Additional context If it is a crash, please attach a stacktrace.

rdmark commented 3 months ago

Right, I completely forgot about SLP. It should be possible to add support, I think.

Thanks for taking a closer look at the new build system. Please report any other shortcomings you come across. :)

ghost commented 3 months ago

Working on it...

ghost commented 3 months ago

@VorpalBlade Please can you checkout the dgsga-srvloc branch and see if this addresses your issue?

Meson now automatically enables SLP (srvloc) support if the slp library is found along with the slp.h header (which is exactly what the autotools macro did). The configuration summary will show if SLP support is enabled or not. You can disable it with the -Dwith-srvloc=false option at configure time.

If you have (Open)SLP installed in an unconventional location you can point to it using the -Dwith-srvloc-path option (the directory pointed to must include lib and include dirs).

VorpalBlade commented 3 months ago

@dgsga I will look at it this weekend, unfortunately I will likely not have time before that. You are way more quick to respond than I am.

rdmark commented 3 months ago

@VorpalBlade FYI the fix has been merged to branch-netatalk-2-4. I am working on a 2.4.1 release now which is time sensitive because of a CVE security patch.

If something doesn't work properly in your testing, we can always do additional fixing and a fast-follow 2.4.x release!