Netatalk / netatalk

Netatalk is a Free and Open Source AFP fileserver. A *NIX or BSD system running Netatalk is capable of serving many Macintosh clients simultaneously as an AppleShare file server.
https://netatalk.io
GNU General Public License v2.0
334 stars 85 forks source link

Remove the bundled wolfSSL library #1527

Closed rdmark closed 1 week ago

rdmark commented 1 week ago

DHCAST128 and RandNum have been migrated to Libgcrypt. PGP has been removed. Hence, we no longer need the bundled wolfSSL library.

rdmark commented 1 week ago

Tested that DHX, RandNum and afppasswd are still working.

NJRoadfan commented 1 week ago

Are these rpath statements still needed for the Randnum and DHX UAM sources in meson.build?

https://github.com/Netatalk/netatalk/blob/main/etc/uams/meson.build#L61-L62

rdmark commented 1 week ago

They were probably never needed, given that the UAMs aren't normal shared libraries. Let's test.

Edit: Seems to be working fine after removing those lines.

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud