search

Netatalk / netatalk

Netatalk is a Free and Open Source AFP fileserver. A *NIX or BSD system running Netatalk is capable of serving many Macintosh clients simultaneously as an AppleShare file server.
https://netatalk.io
GNU General Public License v2.0
343 stars 86 forks source link

Use a single option to turn on Spotlight #1618

Open rdmark opened 2 weeks ago

rdmark commented 2 weeks ago

Right now we have three afp.conf options that all need to be turned on to enable Spotlight.

The two latter were added in https://sourceforge.net/p/netatalk/feature-requests/91/ with little context. I can't immediately think of a reason why you'd ever enable spotlight with also wanting to have tracker and dbus running. Maybe there was some corner case bug or instability early on when spotlight functionality was fresh?

Anyhow, I think these three should be compressed into a single option.

singular0 commented 2 weeks ago

I think this split has something to do with #54 (i.e. if you run indexer as a separate service on system dbus, it starts to make sense).

rdmark commented 2 weeks ago

That's a good point. So there may be a case for controlling the indexer dbus separately.

Can you see a reason for keeping spotlight and tracker (indexer) as separate options? The only reason I can think of would be if we in the future introduced support for multiple indexing backends, and controlled the active backend dynamically rather than at compile time. E.g. https://github.com/Netatalk/netatalk/issues/1409

But at that point the option shouldn't be called start tracker but rather something like indexer backend.

singular0 commented 2 weeks ago

No, at the moment I don't see any scenario in which we may want to enable spotlight without controlling indexer process.