Netatalk / netatalk

Netatalk is a Free and Open Source AFP fileserver. A *NIX or BSD system running Netatalk is capable of serving many Macintosh clients simultaneously as an AppleShare file server.
https://netatalk.io
GNU General Public License v2.0
354 stars 87 forks source link

testsuite: Treat NOT TESTED as non-failure #1663

Closed rdmark closed 3 weeks ago

rdmark commented 4 weeks ago

The testsuite has two test outcomes, SKIPPED and NOT TESTED. By my reading of the code, the former is used when a specific reason is thrown, while the latter is a blanket termination due to some precondition not being fulfilled.

However, while SKIPPED leads to exit code 0, NOT TESTED leads to exit code 2. Consequently, NOT TESTED results trigger CI failures. I think exit code 0 for both is more appropriate.