Netatalk / netatalk

Netatalk is a Free and Open Source AFP fileserver. A *NIX or BSD system running Netatalk is capable of serving many Macintosh clients simultaneously as an AppleShare file server.
https://netatalk.io
GNU General Public License v2.0
354 stars 87 forks source link

testsuite: Treat not tested as non failure and reduce verbosity #1665

Closed rdmark closed 3 weeks ago

rdmark commented 3 weeks ago

Overhaul of testsuite to reduce default verbosity for more readable test logs, and treat NOT TESTED and SKIPPED as non-failure for more consistent results in a CI environment.

Restore a handful of tests that were made functional by recent code improvements.

Standardize on -v for medium verbosity and -V for high level of verbosity logging.

Refashion the -x (Exclude) option for flagging tests that are failing with Netatalk 4.0 for unknown reasons. Investigation required.

Colorize also the SKIPPED test results.

All of this results in a cleaner test log and test report generated by spectest.sh that is much more readable. Sample:

===================
FPAddAPPL page 94
-------------------
FPAddAPPL:test214: test appl - NOT TESTED
===================
FPAddComment page 96
-------------------
FPAddComment:test55: add comment - NOT TESTED
===================
FPByteRangeLock page 101
-------------------
FPByteRangeLock:test60: illegal fork - FAILED
FPByteRangeLock:test80: Resource Fork FPByteLock Read write - NOT TESTED
FPByteRangeLock:test329: FPByteLock 2users DATA FORK - NOT TESTED
FPByteRangeLock:test330: pre OSX trash folder - NOT TESTED
FPByteRangeLock:test410: FPByteLock 2users DATA FORK - NOT TESTED
FPByteRangeLock:test366: Locks released on exit - SKIPPED (need to run individually with -f)
===================
FPByteRangeLockExt page 105
-------------------
FPByteRangeLockExt:test195: illegal fork - FAILED
===================
FPCatSearch page 110
-------------------
FPCatSearch:test225: Catalog search - NOT TESTED
sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
52 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud