search

Netatalk / netatalk

Netatalk is a Free and Open Source AFP fileserver. A *NIX or BSD system running Netatalk is capable of serving many Macintosh clients simultaneously as an AppleShare file server.
https://netatalk.io
GNU General Public License v2.0
354 stars 87 forks source link

only build appletalk docs when enabled #1754

Closed knight-of-ni closed 2 days ago

knight-of-ni commented 2 days ago

fixes #1753

tested to work properly on el9 and f41

rdmark commented 2 days ago

@knight-of-ni Can you please do these changes for the Japanese localization as well? The localization is disabled by default, and can be enabled with -Dwith-manual-l10n=ja if needed for testing.

knight-of-ni commented 2 days ago

I reran the build on el9 and f41 while setting -Dwith-manual-l10n=ja and the build succeeded in both cases.

If any of the filenames of the html or man files had changed during the build, the rpm build process would have caught that and failed. I'm sure the contents are different.

rdmark commented 2 days ago

@knight-of-ni My ask is to modify https://github.com/Netatalk/netatalk/blob/main/doc/ja/manual/meson.build as well so that the AppleTalk html pages in Japanese aren't built.

knight-of-ni commented 2 days ago

Done in ee366dc

rdmark commented 2 days ago

Cheers! Can you also please squash them (e.g. rebase -i HEAD~2) and force push the resulting commit? We like to keep the commit log clean like this.

knight-of-ni commented 2 days ago

Done via: git reset HEAD~2 git commit git push -f