search

Netcentric / accesscontroltool

Rights and roles management for AEM made easy
Eclipse Public License 1.0
150 stars 92 forks source link

Improve naming of RuntimeHelper methods #743

Open kwin opened 2 months ago

kwin commented 2 months ago

Currently the RuntimeHelper exposes two methods related to cloud

  1. isCompositeNodeStore and
  2. isCloudReadyInstance

Both namings are a bit unfortunate, because

  1. in cloud AEM is always started with a composite node store (even during the image build phase). The difference between image build and regular server start is which mount is the default one (apps/libs or the rest) (https://github.com/apache/jackrabbit-oak/blob/8adf6aa2d931e562ec8e69bf4261a250c53fe6f3/oak-store-composite/src/main/java/org/apache/jackrabbit/oak/composite/CompositeNodeStoreService.java#L90).
  2. sounds a bit like distinction between AEM Classic and AEMaaCS (SDK or Cloud), but in fact what is meant here is if the composite node store is used (where only one mount is read-write)

I propose to rename

  1. isCompositeNodeStore to isAppsReadOnly
  2. isCloudReadyInstance to isCompositeNodeStore

That way it is much clearer what is meant.