search

Netcentric / accesscontroltool

Rights and roles management for AEM made easy
Eclipse Public License 1.0
150 stars 91 forks source link

get rid of cq-commons runtime dependency #82

Closed jochenkoschorke closed 8 years ago

jochenkoschorke commented 8 years ago

In the context of #78 and #80 this is a follow up issue which is about removing the dependency to cq-commons completely. Therefore the use of JcrUtil in biz.netcentric.cq.tools.actool.installationhistory.impl.AcHistoryServiceImpl.persistInstalledConfigurations

as well as JCR constants from cq-commons used in biz.netcentric.cq.tools.actool.configreader.YamlMacroChildNodeObjectsProviderImpl should be replaced

kwin commented 8 years ago

The constants are always inlined, therefore they do no lead to a run time dependency (and an import-package statement). So if there are no other suitable constants, just continue to use those.

ghenzler commented 8 years ago

mvn dependency is still there for compilation, but runtime dependency is eliminated (no Import-Package for package in manifest)