Netcentric / aem-htl-style-guide

A style guide for the HTML Template Language (HTL), the templating language use by the Adobe Experience Manager (AEM).
MIT License
138 stars 50 forks source link

Recommendation to use self-closing SLY tags #18

Closed gabrielwalt closed 7 years ago

gabrielwalt commented 7 years ago

What is the reason in change of mind to now prefer <sly></sly> over <sly/>? I'd still recommend to using the self-closing tag.

https://github.com/Netcentric/aem-htl-style-guide/commit/5f3eaa44d89eb4e9225c0fb7b7a7fa1eb1b1d9f1

karollewandowski commented 7 years ago

Hi Gabriel. I'm not repository maintainer, but I'm watching it and know the reason. Change was proposed by me and is explained here: https://github.com/Netcentric/aem-htl-style-guide/pull/7#issuecomment-259107817

gabrielwalt commented 7 years ago

Thank you @karollewandowski, I oversaw your comment and your arguments make sense. Therefore let's avoid <sly/>, thanks!