Update to Stylelint 16 + restore removed rules

lucasenicora commented 3 weeks ago

This PR does 2 main things:

Update all dependencies to latest versions, including Stylelint 16
Restore the stylistic rules that were deprecated and removed from the standard config in Stylelint 15. See https://stylelint.io/migration-guide/to-15/ for more info

Of course this needs a whole major version change due to the breaking changes

Description

The decision of adding the @stylistic package was based on the fact that these rules were already being used by the NC config. So for me it makes sense to keep them even if this deviates from the general approach that Stylelint has decided to keep.

Note that these rules were already lost in v2 of the NC rules, because after Stylelint v15 they had to be manually enabled again in the project, due to them being removed in the stylelint standard configuration.

The configuration has been tested with my own project, and is working as expected. There're a few new warnings being raised by the no-unsupported-browser-features plugin, so the Readme was updated with the newest recommendations

Related Issue

Fixes #17

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] All new and existing tests passed.

quicoto commented 3 weeks ago

Generally the commits messages have a bad format and will not trigger a proper release if merged

Please see https://github.com/Netcentric/stylelint-config/blob/main/docs/CONTRIBUTING.md regarding commit messages which add what they are.

Also here, because this PR is a breaking change, it should be stated, so the version will be bumped to next major

https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit-message-header

lucasenicora commented 3 weeks ago

Ah, I realised before and did a rebase, but did it wrong 😂

lucasenicora commented 3 weeks ago

PR closed in favor of https://github.com/Netcentric/stylelint-config/pull/19 with fixed commit messages

Netcentric / stylelint-config