search

Netcentric / vault-upgrade-hook

Jackrabbit FileVault Install Hook to perform additional actions during package installation
Eclipse Public License 1.0
19 stars 13 forks source link

Get rid of Sling API #18

Closed kwin closed 7 years ago

kwin commented 7 years ago

Since hooks are a concept of Jackrabbit Filevault (and therefore bound to a JCR) only JCR API should be used but not Sling Resource API.

nc-andreashaller commented 7 years ago

Yes, noticed this too and already fixed it in https://github.com/Netcentric/vault-upgrade-hook/pull/8 the OSGi and Sling dependencies are optional and needed only for the handlers.

For https://github.com/Netcentric/vault-upgrade-hook/issues/15 I am already implementing a handler which does not need those dependencies. Will open a PR soon, after the above is merged.

kwin commented 7 years ago

Sling API is only used in the Pipes handler and the script handler, so I think we can close this.