Sling Pipes should get a dedicated handler

Netcentric / vault-upgrade-hook

Jackrabbit FileVault Install Hook to perform additional actions during package installation

Eclipse Public License 1.0

19 stars 13 forks source link

Sling Pipes should get a dedicated handler #3

Closed cwoeltge closed 7 years ago

cwoeltge commented 7 years ago

At the moment the integration of Sling Pipes is rather basic. Instead of using a Groovy script to call Sling Pipes we should use a direct Upgrade Handler.

The missing point is here the first official release as dependency. @npeltier any timeline on that?

npeltier commented 7 years ago

@cwoeltge this should get in pretty soon, you can follow that up here http://markmail.org/search/?q=apache+sling+pipes+release#query:apache%20sling%20pipes%20release+page:1+mid:xkp5klw5vguekae3+state:results

cpilsworth commented 7 years ago

I'm preparing a PR for this change.

Would you accept a couple of minor changes in behaviour?:

Before loading there will be a check to see a provider it is available (i.e. loadClass(...))
If the handler is not available, it will be logged, but the handler will not execute
If there is no handler specified, groovy will continue to be default, if available
If there is a unrecognised handler specified, it will be logged, but groovy will not be used.

This means that for the sample package, things will generally work the same. If the user has sling pipes OR groovy, but upgrade hook will execute without throwing exceptions, but log any failed hooks.

cwoeltge commented 7 years ago

In general yes. I would not log but fail if a handler is configured but not present.

Sent from my iPhone

On 27 Jan 2017, at 13:08, Chris Pilsworth notifications@github.com wrote:

I'm preparing a PR for this change.

Would you accept a couple of minor changes in behaviour?:

Before loading there will be a check to see a provider it is available (i.e. loadClass(...)) If the handler is not available, it will be logged, but the handler will not execute If there is no handler specified, groovy will continue to be default, if available If there is a unrecognised handler specified, it will be logged, but groovy will not be used. This means that for the sample package, things will generally work the same. If the user has sling pipes OR groovy, but upgrade hook will execute without throwing exceptions, but log any failed hooks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

cpilsworth commented 7 years ago

OK, sounds like the right thing to do.

It does however mean for the sample package a user would need both Groovy Console & Sling Pipes installed.

Perhaps splitting the sample package into two might help here. User can choose which package to upload/install based upon whether they are Groovy or Sling Pipes fan.

nc-andreashaller commented 7 years ago

as far as I can see this is already done, right? should we close this issue?