search

Netcentric / vault-upgrade-hook

Jackrabbit FileVault Install Hook to perform additional actions during package installation
Eclipse Public License 1.0
19 stars 13 forks source link

include a backup pipe #36

Closed npeltier closed 5 years ago

npeltier commented 5 years ago

now there is a package pipe (https://sling.apache.org/documentation/bundles/sling-pipes/writers.html), would be nice to embed one that is executed before any of the configured pipes, on a configured set of paths, to backup content before any execution.

nc-andreashaller commented 5 years ago

nice idea, actually that would be already possible with just executing the pipe on the PREPARE phase or do you have a different behaviour in mind?

npeltier commented 5 years ago

@nc-andreashaller yes we could do this that way. The only thing is to have an easy way to configure the paths you want to backup

cwoeltge commented 5 years ago

With PREPARE and the actual order based on names would be all you need. And you can add your path there. What's the actual change you'd suggest?

npeltier commented 5 years ago

yeah, right, saw https://github.com/Netcentric/vault-upgrade-hook/blob/develop/samples/sling-pipes-package/src/main/upgrader/test-sling-pipes/prepare_pipe/conf/%24/.content.xml that could be a backup pipe (e.g. csv | pkg). Was thinking about something more embedded in the hook, but that is probably better for the hook to keep it simple and flexible