Netcentric / vg-macktrucks-com-rd

Franklin Site Redesign for https://www.macktrucks.com
Apache License 2.0
1 stars 12 forks source link

Accordion column block #114

Closed Gonzalo-CG closed 9 months ago

Gonzalo-CG commented 1 year ago

Description

A new Accordion Block (Accordion Column) will be developed to to achieve the design shown on Segment Landing - Figma, this block is used on the Trucks page Trucks - Figma.

This block has 2 variants for the desktop viewport:

Acceptance Criteria

Open Questions

BeckyMedlin commented 1 year ago

@WendyKruger Please see Open Questions above.

BeckyMedlin commented 1 year ago

Per @WendyKruger, the image should change based on the accordion that's opened. Ex: When you click on Bulk Haul, the image needs to change to an image of a Bulk Haul. Name of block: Accordion Column Left (text on left) Variant: Accordion Column Right (text on right)

BeckyMedlin commented 1 year ago

@Gonzalo-CG See Wendy's input above. Name of block = Accordion Column Left (text on left). Please confirm if images can be added to existing accordion. If not, priority needs to be increased.

WendyKruger commented 1 year ago

@BeckyMedlin why is this assigned to me?

BeckyMedlin commented 1 year ago

@WendyKruger I believe I assigned it to you because the Design Question label was still present. I am not aware of any other needs for this one. @DanielaPedrochevd @cogniSyb Can you confirm that this one is ready for refinement? Is anything missing?

DanielaPedrochevd commented 11 months ago

@WendyKruger can you please let us know what the tablet pixels are? Thank you!

WendyKruger commented 11 months ago

@DanielaPedrochevd checking with Matt G., will comment on the Figma file and tag both of you.

DanielaPedrochevd commented 10 months ago

After testing, we will wait until syb comes back to merge so he can review it code wise and branch test.

girishdigrajkar commented 9 months ago

Observations are shared and awaiting fix/resolution/cross comments from Dev team

girishdigrajkar commented 9 months ago

Outstanding issues are fixed and able to get the correct results and hence, marking this ticket to done status.