Netcentric / vg-macktrucks-com-rd

Franklin Site Redesign for https://www.macktrucks.com
Apache License 2.0
1 stars 12 forks source link

JSON File Creation for "All Trucks" filter #102 #123

Closed manuel-vara closed 1 year ago

manuel-vara commented 1 year ago

Fix #102

Updated helix-query.yaml file with new index to get additional metadata elements from PDP pages:

image

Test URLs:

aem-code-sync[bot] commented 1 year ago

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
cogniSyb commented 1 year ago

@manuel-vara With this we’re passing along the page title and page description. We need for the All Trucks page only the model name. Would we achieve that with 1) stripping content that follows a character – like the vertical bar in Volvo Trucks Magazine or 2) add a separate field here?

cogniSyb commented 1 year ago

Shouldn’t we have two images for the All Trucks page?

manuel-vara commented 1 year ago

Shouldn’t we have two images for the All Trucks page?

Good point, I guess this is to be able to add the effect on hovering ecah truck, right? we could add another metadata element named hover image or something similar, where we can place that image.

manuel-vara commented 1 year ago

@manuel-vara With this we’re passing along the page title and page description. We need for the All Trucks page only the model name. Would we achieve that with 1) stripping content that follows a character – like the vertical bar in Volvo Trucks Magazine or 2) add a separate field here?

We can remove the title from the index, indeed, as it's not required but I left it in case Marko needs it to compose the All Trucks page. According to issue https://github.com/Netcentric/vg-macktrucks-com-rd/issues/102

We would need to fetch the following metadata from the PDP Page of each truck:

It looks like 2 images elements would be handy as well (regular and on-hover) Should I add the additional image to PDP metadata?

cogniSyb commented 1 year ago

Closing as we chose a different solution