search

Netcentric / vg-macktrucks-com-rd

Franklin Site Redesign for https://www.macktrucks.com
Apache License 2.0
1 stars 0 forks source link

FR: MT Truck Feature Variant (2 Images and Tab) #148

Closed DanielaPedrochevd closed 10 months ago

DanielaPedrochevd commented 11 months ago

Agile Requirement

Create a block variant that allows editors to add the following design to any page -> https://www.figma.com/file/oNwe2jHIICPMIe551EY62l/Mack-Reskin---Full-Project?type=design&node-id=2243-162475&mode=dev.

Image

Images change when we change of tab.

BeckyMedlin commented 10 months ago

@WendyKruger @cogniSyb needs more info on what kind of images are required. He's not sure how feasible the realisation of alignment of text and images is (when considering a scalable interface)

WendyKruger commented 10 months ago

@cogniSyb not sure what is meant by "what kind of images are required", please elaborate. Are you asking about the alignment/overlay of the top and bottom images when scaled? If that's the issue, can we combine the two images into one and still have the accordion text positioned where it is?

DanielaPedrochevd commented 10 months ago

As per Design agency meeting on 22/11/2023. This issue won't be fixed as we have decided to go with a design that only contains 1 image and that is already available in our existing block library.

BeckyMedlin commented 10 months ago

Per discussion in design meeting, @cogniSyb, @WendyKruger the images need to be combined into one image. No development needed.

Andrei-Boiangiu commented 10 months ago

closing as per above comment

WendyKruger commented 10 months ago

@Andrei-Boiangiu @DanielaPedrochevd @cogniSyb @BeckyMedlin Please refresh my memory, what block does "a design that only contains 1 image and that is already in our existing block library" refer to? Was the intention to combine the images and use the same block as in #43? So it would end up looking like this?

image