search

Netcentric / vg-macktrucks-com-rd

Franklin Site Redesign for https://www.macktrucks.com
Apache License 2.0
1 stars 0 forks source link

Feature carousel #39 #166

Closed Lakshmishri closed 8 months ago

Lakshmishri commented 8 months ago

Fix #39

Test URLs:

aem-code-sync[bot] commented 8 months ago

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

TomaszDziezykNetcentric commented 8 months ago

@Lakshmishri The links are wrong. They should point to netcentric redesign hlx: https://develop--vg-macktrucks-com-rd--netcentric.hlx.page/drafts/lakshmi/v2/v2-feature-carousel https://39-feature-carousel--vg-macktrucks-com-rd--netcentric.hlx.page/drafts/lakshmi/v2/v2-feature-carousel

aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/drafts/lakshmi/v2/v2-feature-carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/drafts/lakshmi/v2/v2-feature-carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/drafts/lakshmi/v2/v2-feature-carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/drafts/lakshmi/v2/v2-feature-carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/drafts/lakshmi/v2/v2-feature-carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/drafts/lakshmi/v2/v2-feature-carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
cogniSyb commented 8 months ago

@Lakshmishri The links are wrong. They should point to netcentric redesign hlx: https://develop--vg-macktrucks-com-rd--netcentric.hlx.page/drafts/lakshmi/v2/v2-feature-carousel https://39-feature-carousel--vg-macktrucks-com-rd--netcentric.hlx.page/drafts/lakshmi/v2/v2-feature-carousel

Thanks @TomaszDziezykNetcentric for pointing that out. I’ve made a mistake with the recent release. I’ll update the URLs again on Monday

taimurCognizant commented 8 months ago

@Lakshmishri in firefox the carousel image doesn't have the correct aspect ratio

cogniSyb commented 8 months ago

@Lakshmishri in firefox the carousel image doesn't have the correct aspect ratio

Adding aspect-ratio: 1; on .v2-feature-carousel__image-wrapper seems to fix it. The image should be positioned 100% over <picture> to make use of object-fit

aem-code-sync[bot] commented 8 months ago
Page Scores Audits Google
/drafts/lakshmi/v2/v2-feature-carousel PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
Lakshmishri commented 8 months ago

@Lakshmishri in firefox the carousel image doesn't have the correct aspect ratio

Adding aspect-ratio: 1; on .v2-feature-carousel__image-wrapper seems to fix it. The image should be positioned 100% over <picture> to make use of object-fit

I have fixed using height and width as 100% , as providing aspect-ratio didn't work. Check and let me know

@taimurCognizant @cogniSyb