search

Netcentric / vg-macktrucks-com-rd

Franklin Site Redesign for https://www.macktrucks.com
Apache License 2.0
1 stars 12 forks source link

Pencil Promo block #108 #195

Closed markovukiceviccn closed 10 months ago

markovukiceviccn commented 11 months ago

Fix #108

Banner blocks can be enabled or disabled by changing the data attributes in page word file:

Section Metadata

Pencil banner black | disabled Pencil banner copper | pencil-banner-copper Promo block gold | promo-banner-gold Promo block copper | promo-banner-copper

#

each block now is independent and Section metadata is no longer needed, but author is responsible to add the proper variant to the block

Also Fix

in All-trucks block had a tiny style issue, that now is fixed

#

Test URLs:

aem-code-sync[bot] commented 11 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [1dafbdc](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/195/commits/1dafbdc2b2ae3b35d2a7d5b2d5075a3e98612c3b) :white_check_mark: (latest) * [3c7315b](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/195/commits/3c7315b45f2b5c5471b81b494744221e1680c20a) :white_check_mark: * [8a45805](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/195/commits/8a45805084b51a4427d9c735239d9edd5157193c) :white_check_mark: * [c9d3c81](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/195/commits/c9d3c81374cd42cef1d1a8792e61110192a4dded) :white_check_mark: * [b79d2af](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/195/commits/b79d2af8a2f8ba43e57914003d9d95e0d7895f76) :white_check_mark: * [62a4bc5](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/195/commits/62a4bc5acd248cfcdc011456e9ba05343614d8fe) :white_check_mark: * [3fff0de](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/195/commits/3fff0de2fc6065e9e813f7363266a3e3414ede6a) :white_check_mark: * [0abab93](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/195/commits/0abab93bd47456f5a07ce44f90c93084fa3edec3) :white_check_mark: * [3809395](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/195/commits/3809395135097d43842a6df3eece3d3a3c1ec1a2) :white_check_mark: * [d8e67a0](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/195/commits/d8e67a03032c417c025d933845bf82d4a7129144) :white_check_mark: * [c3e557c](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/195/commits/c3e557c3ec3d9b39cf71889722ca6fe55f0c38cc) :white_check_mark: * [cd6205f](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/195/commits/cd6205f15e5a8d070b207b2ba226e372013134f6) :white_check_mark: * [b2f5fe1](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/195/commits/b2f5fe1668b1df63f9a52bca8c15aaef4a990505) :white_check_mark: * [21a3a2a](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/195/commits/21a3a2a2a373c53336f4e4cde1989f8ace40a8af) :white_check_mark:
aem-code-sync[bot] commented 11 months ago
Page Scores Audits Google
/drafts/marko/v2/all-trucks PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
SantiagoHomps-NC commented 10 months ago

IDK if this is regarding this issue but since the block is on this page I found it and could be solved. There is a small gap in the images of the 'all-trucks' block when hovered. This could be solved by deleting line 288 (align-items property) from 'v2-all-trucks.css' file.

Screenshot 2024-01-02 at 16 43 10
cogniSyb commented 10 months ago

Min height for this should be removed , it should just have padding like here

Should the component be full width, so if screen is greater than 1440px, there background for entire block ? @cogniSyb , @DanielaPedrochevd ? The component should be full width indeed