search

Netcentric / vg-macktrucks-com-rd

Franklin Site Redesign for https://www.macktrucks.com
Apache License 2.0
1 stars 0 forks source link

Incorrect section background on Redesign pages #199

Closed cogniSyb closed 4 months ago

cogniSyb commented 6 months ago

On redesign pages, the wrong background colour is used for sections marked with "black background"

Expected: Secondary/Graphite #1D1D1D Result: Primary/Black #000000

See below that there’s a specificity issue in the CSS: Screenshot 2024-01-11 at 13 15 36

BeckyMedlin commented 5 months ago

@DanielaPedrochevd Is this a bug? Please add milestone for this ticket.

WendyKruger commented 5 months ago

@cogniSyb the section metadata style that gives the graphite background color is dark-background

cogniSyb commented 5 months ago

Thanks @WendyKruger. Still that means a code change required to fix alignment issues:

Screenshot 2024-02-06 at 15 36 05

The margins are correct for a section with "black background" set. I’ll remove "black background" and will apply the right margins for "dark background"

shirin27 commented 4 months ago

Kamino cloned this issue to hlxsites/vg-macktrucks-com