search

Netcentric / vg-macktrucks-com-rd

Franklin Site Redesign for https://www.macktrucks.com
Apache License 2.0
1 stars 12 forks source link

Accordion column block #114 #203

Closed jonatan-lledo-netcentric closed 9 months ago

jonatan-lledo-netcentric commented 10 months ago

Variants

The left variant can be detected by positioning the images in the right side or by adding the variant keyword Left. For the Gray Background variant, can be added as a section metadata as style option ~OR as a regular variant.~

the red mark over the title is added always by the block

Test URL

drafts/jlledo/v2/accordion-column-demo

#

Fix #114

Test URLs:

aem-code-sync[bot] commented 10 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [c527929](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/203/commits/c52792939af3f7d9a5bc1de579534801ec27a3b3) :white_check_mark: (latest) * [68e8d38](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/203/commits/68e8d38ff912717050e318abc603d89e43d7533f) :white_check_mark: * [760721d](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/203/commits/760721d9b4038c22f44e6f88a741ec25e4e24c10) :white_check_mark: * [a7407eb](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/203/commits/a7407eb8173aafdb5cf25b7845eb216451f6bda5) :white_check_mark: * [ec6f1d1](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/203/commits/ec6f1d1a589e2c10e8889f874eaf5cc88457e9be) :white_check_mark: * [85bed9f](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/203/commits/85bed9fbfc0a61bbfb0b042a2029cf343b2f7b50) :white_check_mark: * [a3415d3](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/203/commits/a3415d3feac726a04aa79386a797e43a7bfa5d09) :white_check_mark: * [3107137](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/203/commits/3107137837bff81544e67fe1b077cbd6a66092ba) :white_check_mark: * [cd182c6](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/203/commits/cd182c650064ebaaf8634664d54a2837e93a9b64) :white_check_mark: * [118f723](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/203/commits/118f723e823564560b57ec5e3a8beda2fb8d6089) :white_check_mark: * [307d154](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/203/commits/307d1543973919482b2b96354606d905386cd338) :white_check_mark: * [4ef37f5](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/203/commits/4ef37f5cc46ba61d73a923db5ef47c8d6a61c10c) :white_check_mark: * [6738ee8](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/203/commits/6738ee853f0870bab2aa9b5cd9397f1c6b6d1e40) :white_check_mark: * [90fb3de](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/203/commits/90fb3de019c1d7e9cb651d4b4c0ef22298ad3bb7) :white_check_mark: * [68c1c2e](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/203/commits/68c1c2eb36a91d78f878610682f040cbb8d0715a) :white_check_mark: * [3dc6e60](https://github.com/Netcentric/vg-macktrucks-com-rd/pull/203/commits/3dc6e606e1ff4cf3555ac0e8944be72c920a9f23) :white_check_mark:
aem-code-sync[bot] commented 10 months ago
Page Scores Audits Google
/drafts/jlledo/v2/accordion-column-demo PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
SantiagoHomps-NC commented 10 months ago

I see some space left of the image that makes the VW a little bit wider than it should... dont know where this is coming

Screenshot 2024-01-22 at 12 51 49
SantiagoHomps-NC commented 10 months ago

Also check margins/paddings for desktop in v2-accordion-column__item-header-button