Netcentric / vg-macktrucks-com-rd

Franklin Site Redesign for https://www.macktrucks.com
Apache License 2.0
1 stars 0 forks source link

27 hero variant for pdp #76

Closed markovukiceviccn closed 1 year ago

markovukiceviccn commented 1 year ago

Link to the issue: https://github.com/Netcentric/vg-macktrucks-com-rd/issues/27

Test URLs:

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/marko/pdp PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
markovukiceviccn commented 1 year ago
Screenshot 2023-09-20 at 10 25 01

The model name of the truck should align with start of in page navigation as per designs

@Lakshmishri @cogniSyb

Sure I can reduce the right padding by 100 pixels but in that case any longer name will break out to the left like on this screenshot.

Screenshot 2023-09-20 at 10 45 16
cogniSyb commented 1 year ago
Screenshot 2023-09-20 at 10 25 01

The model name of the truck should align with start of in page navigation as per designs

@Lakshmishri @cogniSyb

Sure I can reduce the right padding by 100 pixels but in that case any longer name will break out to the left like on this screenshot. Screenshot 2023-09-20 at 10 45 16

Rather test with "LR Electric", which is currently the longest product name. I don’t see given the DOM structure how this can be contained in the wrapper-width. @Lakshmishri shall we mark this as a bug instead and pick it up later?

markovukiceviccn commented 1 year ago
Screenshot 2023-09-20 at 10 25 01

The model name of the truck should align with start of in page navigation as per designs

@Lakshmishri @cogniSyb Sure I can reduce the right padding by 100 pixels but in that case any longer name will break out to the left like on this screenshot. Screenshot 2023-09-20 at 10 45 16

Rather test with "LR Electric", which is currently the longest product name. I don’t see given the DOM structure how this can be contained in the wrapper-width. @Lakshmishri shall we mark this as a bug instead and pick it up later?

@cogniSyb @Lakshmishri I would reduce the right padding to 40px and if the title is too long let it break out to left if needs more space. Like Bruce Lee once said: Be like water :) WDYT?

Screenshot 2023-09-20 at 11 44 31
Lakshmishri commented 1 year ago
Screenshot 2023-09-20 at 10 25 01

The model name of the truck should align with start of in page navigation as per designs

@Lakshmishri @cogniSyb Sure I can reduce the right padding by 100 pixels but in that case any longer name will break out to the left like on this screenshot. Screenshot 2023-09-20 at 10 45 16

Rather test with "LR Electric", which is currently the longest product name. I don’t see given the DOM structure how this can be contained in the wrapper-width. @Lakshmishri shall we mark this as a bug instead and pick it up later?

@cogniSyb @Lakshmishri I would reduce the right padding to 40px and if the title is too long let it break out to left if needs more space. Like Bruce Lee once said: Be like water :) WDYT? Screenshot 2023-09-20 at 11 44 31

@cogniSyb , @markovukiceviccn - yes we can mark this as bug and fix it later

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/marko/pdp PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/marko/pdp PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
kesiah commented 1 year ago

Also, provide different pages where we can check the color difference for "Electric trucks"

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/drafts/marko/pdp PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI