Netcentric / vg-macktrucks-com-rd

Franklin Site Redesign for https://www.macktrucks.com
Apache License 2.0
1 stars 0 forks source link

fix regression with typography #78, fix footer alignment #77 #79

Closed cogniSyb closed 1 year ago

cogniSyb commented 1 year ago

Fix #77 #78

Test URLs:

Redesign-only custom properties (CSS variables) are moved down in the CSS file, to prevent more regression being created. All font-sizes returned to former values, reflecting state on live website. Overrides are placed accordingly.

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
cogniSyb commented 1 year ago

With these changes I see it broken for some redesign components

Screenshot 2023-09-20 at 09 16 07

Thanks @Lakshmishri, there was a specificity issue. It’s now fixed. I’ve changed this title and for newsletter to have the correct font set (Helvetica Neue LT Pro, 75 Bold instead of Helvetica Neue LT Pro, 65 Medium)

Lakshmishri commented 1 year ago

With these changes I see it broken for some redesign components

Screenshot 2023-09-20 at 09 16 07

Thanks @Lakshmishri, there was a specificity issue. It’s now fixed. I’ve changed this title and for newsletter to have the correct font set (Helvetica Neue LT Pro, 75 Bold instead of Helvetica Neue LT Pro, 65 Medium)

I still see it broken for cards component headings, do we want to fix that ?

and can you edit this PR to be merged to develop ?

aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI