Netcentric / vg-volvotrucks-us-rd

Franklin Site Redesign for https://www.volvotrucks.us/
Apache License 2.0
1 stars 0 forks source link

Bug: Medium - Issues using the new redesign video hero block on a new page #244

Closed ZoeBeykirch closed 10 months ago

ZoeBeykirch commented 12 months ago

We are trying to build a new page and tried copying and pasting the new redesign header block from the Super Truck 2 page and are having issues getting it to work as expected. While we added the same hero video component as in Super Truck 2, it is not getting viewed in full width. There is some white space at both edges that we can't understand how to remove. When we tried to update the page to be the new redesigned style, the text and content then becomes mis-aligned. We need help in making this new hero block on the new page full width and removing the extra space to behave as expected without making the rest of the components on the page become mis-aligned.

Link - https://main--vg-volvotrucks-us--hlxsites.hlx.page/electromobility/

Screen shot - Image

cogniSyb commented 11 months ago

Pages with redesign blocks (V2 blocks) need the class redesign-v2 added to the page. So redesign-v2 needs to be added to the style metadata

Varunvolvo commented 11 months ago

We have tried by adding the style. But the hero gets fixed, But the below content width also gets scewed in the main body. So isnt there any other way where only the hero video can be fixed and rest of the below content same as it is now.

manuel-vara commented 11 months ago

@Varunvolvo can you check now, please?

Varunvolvo commented 11 months ago

Hi Manuel, sorry for the delay in feedback. I was in leave for two days. I checked but no luck with the changes.

We only need the hero video banner to be fixed, If we apply v2-redesign the entire page style is getting changed. Can you just help us in style only for the video block (by making it view in full width) - rest of the blocks need to be the same.

cogniSyb commented 11 months ago

We can’t do that @Varunvolvo, as this is not possible with the chosen approach of the redesign project. The redesign blocks are created with a dependency on the redesign class for global styles.

In our current sprint we’re working on #89 and #181. These blocks together with v2-content-card, v2-dealer-locator-teaser, v2-section-header, v2-video and v2-truck-lineup could be sufficient to finish the page.

BeckyMedlin commented 8 months ago

@Varunvolvo @ZoeBeykirch The tickets @cogniSyb noted in his comments above are completed. Can you verify that this issue is resolved using the functionality delivered in those tickets? If not, we will need to open a new ticket.

ZoeBeykirch commented 8 months ago

Confirmed close on this one.