Open C-512L opened 3 weeks ago
That looks like a reasonable addition to me, if you're interested in implementing this feel free to submit a PR. Otherwise, I could implement it myself.
That looks like a reasonable addition to me, if you're interested in implementing this feel free to submit a PR. Otherwise, I could implement it myself.
I see the project uses both Kotlin and Java in a lot of places. Are there any contributing guidelines for the project on whether certain functionality should be written on Java or Kotlin?
The Kotlin is a fairly recent addition, in general I have been writing new code in Kotlin and slowly rewriting the Java into Kotlin. The exception is classes which are directly exposed to the lua interface using CoerceJavaToLua
, because LuaJ doesn't support Kotlin. These classes are contained under org.netdex.androidusbscript.lua
and have a special Proguard rule to avoid scrambling names.
I am writting a Multi-ISO boot script and one thing I found missing is the ability to call from lua to open a selection dialog with options passed by lua. The code i conceptualize in lua could look something like this:
I have dived into the Java/Kotlin side of the code a little so If I have spare time, I might even try to make a PR implementing it.