search

Netflix-Skunkworks / Scumblr

Web framework that allows performing periodic syncs of data sources and performing analysis on the identified results
Apache License 2.0
2.64k stars 318 forks source link

Use environment variables to set HTTP endpoint #104

Closed oogali closed 8 years ago

oogali commented 8 years ago

Currently, the code defaults to using values from the configuration file with no other way to override them.

These creates a challenge in turning this into a Docker container, so I've changed the configuration files to accept values via environment variables, and fall back to sensible defaults.

You can use SCUMBLR_HTTP_HOST and SCUMBLR_HTTP_PROTO to set the hostname and protocol (http or https) in either development or production environments.

If these parameters aren't provided, the effective configuration will fall back to http://localhost:3000 and https://scumblr for development and production respectively.

oogali commented 8 years ago

The original commit used symbols as keys for the environment variables, which obviously doesn't work.

I fixed that by changing the keys to strings, and squashed it into a single commit (no need to pollute commit history).

sbehrens commented 8 years ago

We have released Scumblr 2.0 and will no longer be accepting pull requests on the 1.x branch. Please upgrade to Scumblr 2.0 and submit any pull requests if your issue was not already addressed.