search

Netflix-Skunkworks / Scumblr

Web framework that allows performing periodic syncs of data sources and performing analysis on the identified results
Apache License 2.0
2.64k stars 317 forks source link

Spelling #107

Closed jsoref closed 7 years ago

jsoref commented 7 years ago

This is a series of spelling fixes to Scumblr (including one for misspelling the product name...).

This PR can, of course, be folded together. However, initially, it is much easier to rebase and discuss individual concepts as individual commits. It's also possible to split this PR into a couple, one for API changes and one for other things, but there aren't many such items in this PR and I'd rather not spend that time on it.

sbehrens commented 7 years ago

Hi Jsoref,

We've done a bunch of code changes since the 1.0 release. Any way you could run your spellchecker against the new code as well?

jsoref commented 7 years ago

@sbehrens: Here's a set of fixes for things which were visibly misspelled as identified in insertions/removals between when I branched off.

sbehrens commented 7 years ago

Nice, thanks again. Would be interested in you checking some of our other security tools using your spelling scripts: https://github.com/netflix/sketchy and https://github.com/netflix/sleepy-puppy if you are willing to help!

jsoref commented 7 years ago

I can, but at some point, you're going to need to update lodash. They misspelled forty (it seems to be a common error, I remember some other project recently making the same mistake..) -- and I haven't hit their project yet...

https://github.com/Netflix/sketchy/pull/37

jsoref commented 7 years ago

Thanks for taking these PRs. FWIW, this output is manual, I have a script which lists tokens that it doesn't recognize as words, and then it's up to me to decide based on what's left which things are typos and which are ok. (And I'm not perfect.)

Some stats:

Tokens Selected Words Repo/PRs
275 21 19 Netflix/sketchy#37
1058 39 35 Netflix/Scumblr#107 Netflix/Scumblr#109
4816 26 20 Netflix/sleepy-puppy#11

Because everything after the first column is manual (I do have a tool to sort the PRs alphabetically, although it looks like I didn't necessarily run it for some of these), it isn't a guarantee there aren't other errors. -- While trying to build this table, I found two that I had missed.