search

Netflix-Skunkworks / Scumblr

Web framework that allows performing periodic syncs of data sources and performing analysis on the identified results
Apache License 2.0
2.64k stars 317 forks source link

Initial Scumblr docker configuration #129

Open sbasgall opened 7 years ago

sbasgall commented 7 years ago

docker-compose for Scumblr issue #54

It mostly follows best practices although there are a few warts. I made a few decisions with best judgement and open to any feedback.

Thanks for making Scumblr!

sbasgall commented 7 years ago

I removed the default credentials based on feedback the project provided to PR #99

ahoernecke commented 7 years ago

Hi @sbasgall,

Thanks, this looks great! I'm going to test it out and assuming all goes well we will roll it into a separate repo and provide instructions for using it in the wiki.

Thank you again!

sbasgall commented 7 years ago

@ahoernecke Great news!

It should come up just fine. There are a couple improvements I'd like to make eventually but I wanted to share what is already done so it's easier for people to evaluate and launch this great service!

sbasgall commented 7 years ago

Hi @ahoernecke,

I'm not sure what the project's plans are to create a separate repo for the Docker image build files but having a repo in the style of the official docker image packaging might be nice.

Here is an official example for mysql: https://github.com/docker-library/mysql

Here is a third party example for Vault: https://github.com/hashicorp/docker-vault https://github.com/docker-library/docs/tree/master/vault

Hashicorp has a model where commits trigger a new docker image build to upload to a public container registry after running some CI tests.

Following this pattern would mean things like docker-compose.yml and possibly scumblr-vars.envmight still technically belong in the main project repo.

If the goal is to keep the main project repository free of any docker related files using a layout similar to this still seems worth considering.

Thanks!