search

Netflix-Skunkworks / Scumblr

Web framework that allows performing periodic syncs of data sources and performing analysis on the identified results
Apache License 2.0
2.64k stars 319 forks source link

Missing move_vulnerability_task or create_vulnerability_jira_task in app/views/results/metadata/_vulnerability.html.erb error #221

Closed xntrik closed 6 years ago

xntrik commented 6 years ago

Hey Folks,

Running this 'out-of-the-box' with version 2.1.0 I'm noticing errors getting thrown when expanding the 'Vulnerabilities' accordion on the 'Results' page.

The issues appear to be: https://github.com/Netflix/Scumblr/blob/master/app/views/results/metadata/_vulnerability.html.erb#L37 and https://github.com/Netflix/Scumblr/blob/master/app/views/results/metadata/_vulnerability.html.erb#L50

Both of those have an if check for whether move_vulnerability_task or create_vulnerability_jira_task is defined, which they are, unfortunately, they're nil.

sbehrens commented 6 years ago

Howdy, sorry Christian for the late reply. We'll take a look at this one.

sbehrens commented 6 years ago

Fixed, defined is always set but we should have used present since that will only return if the object is not nil.