Netflix-Skunkworks / Scumblr

Web framework that allows performing periodic syncs of data sources and performing analysis on the identified results
Apache License 2.0
2.64k stars 319 forks source link

Node.js 4.x LTS Argon is no longer actively supported #244

Closed infracritical closed 5 years ago

infracritical commented 5 years ago

You may want to update your instructions...

===================

root# curl -sL https://deb.nodesource.com/setup_4.x | sudo -E bash -

=======================================================================

                          DEPRECATION WARNING                            

Node.js 4.x LTS Argon is no longer actively supported!

You will not receive security or critical stability updates for this version.

You should migrate to a supported version of Node.js as soon as possible. Use the installation script that corresponds to the version of Node.js you wish to install. e.g.

=======================================================================

Continuing in 20 seconds ...

Installing the NodeSource Node.js 4.x LTS Argon repo...

sbehrens commented 5 years ago

Hi,

I didn't catch we require NodeJS as a dependency. Looks like it's here in the install guide:

curl -sL https://deb.nodesource.com/setup_4.x | sudo -E bash -
sudo apt-get install -y nodejs

I'll take a look at what it's actually used for (wasn't sure we actually need this).

sbehrens commented 5 years ago

updated install instructions, thanks for the catch (we don't need to pin to an old version we just use node for asset pipeline management).