Netflix-Skunkworks / aardvark

Aardvark is a multi-account AWS IAM Access Advisor API
Apache License 2.0
472 stars 77 forks source link

plus sign in arn got skipped #28

Closed GitOnion closed 5 years ago

GitOnion commented 7 years ago

Hi,

We encountered an issue, likely from an awsconsole.js function, advisor.generateReport, that ARN with "+" sign in it (as part of the user's name) got parsed to space in the POST request sent to AWS and returned this error message:

ERROR GenerateServiceLastAccessedDetails arn:aws:iam::123456789012:user/foo+bar. Skipping... {"readyState":4,"responseText":"{\"errors\":[{\"message\":\"ARN arn:aws:iam::123456789012:user/foo bar does not exist.\",\"code\":\"NoSuchEntity\",\"type\":\"Sender\"}]}","responseJSON":{"errors":[{"message":"ARN arn:aws:iam::123456789012:user/foo bar does not exist.","code":"NoSuchEntity","type":"Sender"}]},"status":404,"statusText":"Not Found"}

I think this issue is caused by string parsing at AWS end, but wonder what's your opinion and if you have similar issues. Thanks!

mcpeak commented 6 years ago

hey @GitOnion this one slipped through somehow. Did you ever figure out how to work around it?

I agree, this looks like it's failing AWS backend validation.

mcpeak commented 5 years ago

Closing old issue.