Netflix-Skunkworks / atlas-system-agent

Agent that reports system metrics through SpectatorD.
Apache License 2.0
5 stars 8 forks source link

disk.io.ops and disk.percentBusy should not report for metadisk devices #108

Closed copperlight closed 2 years ago

copperlight commented 2 years ago

Multiple (RAID) devices do not provide the timing data necessary for calculating the disk.io.ops and disk.percentBusy statistics. Since we do not have the data necessary, these metrics should not be reported.

Prior to this change, these timers would not report the totalTime and the totalOfSquares components because they were zero increments. The count component would report the number of times an attempt was made to report the metric and the max component was always zero. As a result, these timers appeared to be counters in Atlas UI.

The disk.io.bytes metrics remain relevant for mulitple devices.